Contribute to dshanske/syndication-links development by creating an account on GitHub.
For syndication to indieweb.xyz the displayed result (set for icon only) is giving a relatively interesting “info” icon,which is a reasonable proxy, but sadly the hover text is also “info” instead of a more useful or expected “indieweb.xyz”.
For syndications to reading.am (which I’m guessing still doesn’t have a service specific icon) instead of giving the old default image of a globe icon, it’s not displaying anything at all. I haven’t tested specifically, but are unmapped urls still given that old default icon?
I’m still seeing issues with my chrisaldrich.wordpress.com URL. Previously it displayed a blank space (presumably not able to understand the inpub), but the newer version is displaying the word “WordPress” even when I’m using icons only. (Example: https://boffosocko.com/2019/02/14/a-sketch-for-an-indieweb-bullet-journal/#Syndicated%20copies) My initial inclination is that the two instances of “WordPress” at https://github.com/dshanske/syndication-links/blob/057733d921b485cf8f0eb98b28b104ccb708bd21/includes/class-syn-meta.php#L333 are both CamelCase when all the other examples around/near that segment of code are all lower case.
Thank you.
I’m not sure why I had never manually done the fix before, but I’ve had issues1 2 with the Syndication Links plugin showing icons for the reading.am service and my old chrisaldrich.wordpress.com site, which I primarily use as a pseudo-mirror/backup to my primary site. I figured there had to be a way to force them in instead of relying on the set up to process the links and show something. Reading.am doesn’t work because there isn’t an svg available for it and though there’s a WordPress icon, the plugin’s parser doesn’t seem to be able to recognize the subdomain properly.
Within the code at class-syn-link-domain-icon-map.php, I added the following two lines to the obvious spot in the list within the code to fix the icon issues I was having:
'chrisaldrich.wordpress.com' => 'wordpress','reading.am' => 'book',
I then reuploaded the edited file to my server. Essentially I’m hard-coding the domain name and the default icon I’d like to have the plugin display.
If the plugin is updated, I’ll obviously have to manually add them again, but the disappearance of the icons again will be pretty obvious and this post will document the necessary changes.
Although upon tweaking this I’m noticing that the reading.am icon isn’t working (I also tried ‘website’ instead of ‘book’ but that didn’t work either). Perhaps the .am tld is causing an issue? Alas…
I suspect that there’s some other bug hiding in the works as one or both of the two types of links above should default to the generic ‘website’ icon when a syndication link exists, but the system isn’t able to specify a particular icon. There may be some small if/else bug hiding in the logic of the plugin.
Believe this is resolved